[TYPO3-core] RFC #17267: Live search is unusable with Oracle

Xavier Perseguers typo3 at perseguers.ch
Mon Jan 24 18:38:37 CET 2011


Hi,

> Thanks for taking care of this one! +1 on reading and testing (non-dbal)
> with two minor comments...
>
> * I think the CGL discourages assigning variables in an if statement,
> but suggests wrapping them in an extra set of parenthesis when it is done.
>
> * In the if statement handling the PID field, uidPos is still used as
> the variable name instead of pidPos.

Thanks for the review. Will take care of that!

Xavier


More information about the TYPO3-team-core mailing list