[TYPO3-core] RFC #17065: Use Swift Mailer in core (was: Swift Mailer Adapter does not support file attachment and nested MIME parts)

Ernesto Baschny [cron IT] ernst at cron-it.de
Fri Jan 21 22:36:23 CET 2011


Jigal van Hemert schrieb am 21.01.2011 11:50:

> While testing with Susanne a few changes:
> - use defaultMailFromAddress in SYS section instead of my own
> - removed @var comments which were not needed
> - renamed sendtheMail to sendTheMail (PHP treats function names as
> case-insensitive and this is proper camelCasing); name must stay the
> same because it is part of the current API.
> 
> Attached v2

Thanks a lot, Jigal! And here is my review, just "tiny changes":

1)
Added t3lib_utility_Mail::getSystemFrom() which returns an array ready
to pass to "setFrom()" (also including the newly introduced "name" if
there is any configured).

2)
Use that in places where only getSystemFromAddress() was used before
(reports task, etc)

3)
Attachments of formmail were not working (file needs to be there until
the mail is send), so I moved deleting it to the destructor.

4)
Test in Install tool now only uses t3lib_mail, we don't want to test
unsupported methods anymore. Also fixed the text describing the test.

5)
Added a X-Mailer: TYPO3 header on all outgoing mails, like
t3lib_htmlmail used to do.

6)
Deprecated:
- TYPO3_CONF_VARS[SYS][forceReturnPath] (added a comment in Install Tool)
- TypoScript setting "config.incT3Lib_htmlmail" (with logging)
- t3lib_htmlmail !!!


Unclear about:
typo3\sysext\cms\tslib\media\scripts\fe_adminLib.inc
typo3\sysext\statictemplates\media\scripts\fe_adminLib.inc
- still uses t3lib_htmlmail.. deprecate it? is it worth it? To be
discussed in v4 list.

+1 on reading and testing everything.

Attached patch (v3) was committed to trunk, rev 10227.


Highlight hunk from this patch:

--- t3lib/class.t3lib_htmlmail.php      (Revision 10226)
+++ t3lib/class.t3lib_htmlmail.php      (Revision 10227)
@@ -245,6 +245,7 @@
         * @return      void
         */
        public function t3lib_htmlmail() {
+               t3lib_div::logDeprecatedFunction();
                $this->forceReturnPath =
$GLOBALS['TYPO3_CONF_VARS']['SYS']['forceReturnPath'];

                $this->mailer = 'TYPO3';


Cheers,
Ernesto
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 17065_v3.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20110121/4ca7524a/attachment-0001.txt>


More information about the TYPO3-team-core mailing list