[TYPO3-core] RFC #17102: migrateWorkspaces in Install-Tool doesn't show up in all relevant situations

[Tolleiv.Nietsch]

Am 18.01.2011 12:30, schrieb François Suter:
>
> Indeed if we imagine a situation (some rather broken installation) where
> one of the extensions is not installed (hence $result = TRUE), both
> tables exist, but sys_workspace is empty. In such a scenario
>
> $result = $wsCount > 0;
>
> will change $result to FALSE and update will not happen. Using a OR
> prevents this from happening.
>

So true, thanks :)

> Finally the test for draft workspace is triggered only if all previous
> tests have returned FALSE. This means that if any previous test returned
> TRUE, this test will not happen and the user will not see the message
> about draft workspace migration, thus losing an important information.
> I'm aware that the check is quite heavy, but I think it's ok to have it,
> since this is just about the migration wizard, which is not used every
> day. I changed the logic to always execute this check.

Well I'm OK with it - the checks involve a lot of database action but 
you're right - the information itself is more important.

Cheers,
Tolleiv

-- 
Tolleiv Nietsch
www.tolleiv.de - www.aoemedia.de
Twitter: http://www.twitter.com/tolleiv