[TYPO3-core] RFC #17102: migrateWorkspaces in Install-Tool doesn't show up in all relevant situations

[François Suter]

Hi,

> There was one typo in the table name "sys_workspace_stages" instead of
> "..._stage" and I changed the wording of the other reason a bit, from
> "need to" to "will be", because if you already used the wizard, the
> check does not "need to" be done but "will be" done anyway;)

And here's v3 which corrects the following:

- booleans are uppercase (CGL)
- added a <br /> before "Why do you need this wizard?" otherwise it's 
stuck to the explanation paragraph

More importantly I changed the test with the sys_workspace count from:

$result = $wsCount > 0;

to

$result |= $wsCount > 0;

Indeed if we imagine a situation (some rather broken installation) where 
one of the extensions is not installed (hence $result = TRUE), both 
tables exist, but sys_workspace is empty. In such a scenario

$result = $wsCount > 0;

will change $result to FALSE and update will not happen. Using a OR 
prevents this from happening.

Finally the test for draft workspace is triggered only if all previous 
tests have returned FALSE. This means that if any previous test returned 
TRUE, this test will not happen and the user will not see the message 
about draft workspace migration, thus losing an important information. 
I'm aware that the check is quite heavy, but I think it's ok to have it, 
since this is just about the migration wizard, which is not used every 
day. I changed the logic to always execute this check.

Attached v3 with all these changes. Do you agree with them? On my side 
I'm +1 on reading and testing.

Cheers

-- 

Francois Suter
Cobweb Development Sarl - http://www.cobweb.ch
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 17102_v3.patch
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20110118/070dfe1d/attachment.txt>