[TYPO3-core] RFC: #15129: Backend search is unusable for editors

Christian Kuhn lolli at schwarzbu.ch
Fri Jan 14 20:10:45 CET 2011


Hey,

On 01/06/2011 09:37 AM, Sebastian Fischer wrote:
> On 05.01.2011 23:30, Jigal van Hemert wrote:
>> On 5-1-2011 15:37, Sebastian Fischer wrote:
>>> BT reference: http://bugs.typo3.org/view.php?id=15129
>>> Only the first dbmount is used for searches if you try to search via the
>>> search box to the top right.

This patch won't make it to 4.2 anymore (only heavy issues and 
security), even 4.3 might be questionable, imho Oliver should decide.

Patch is not ready yet:

Nitpicks:
if (strlen($this->searchString) AND 
strlen($GLOBALS['BE_USER']->groupData['webmounts'])) {
AND -> &&

$pidSelect = 'pid in (' . implode(',', $pageIds) . ')';
in -> IN

Issues:
This code is executed for every table again, maybe we could store the 
output somewhere?
pidList is already determined in start(). If you overwrite it in 
makeQueryArray() again, the pidList is broken if the search input at the 
bottom of the list module is searched: It then always starts at top 
mountpoint (0 for admins), instead of currently selected subpage.

Regards
Christian


More information about the TYPO3-team-core mailing list