[TYPO3-core] RFC #15133: Bug: Rendering Images with ImageMagick fails in case of file-permissions

Christian Kuhn lolli at schwarzbu.ch
Mon Jan 10 21:16:24 CET 2011


Hey.

On 01/10/2011 10:36 AM, Ernesto Baschny [cron IT] wrote:
> Hi Christian, since this is related to your fix in #3977, it would be
> cool if you could take a look at if before Wednesday (and even commit
> it, if you find it ok). There might be missing test cases, thou.
>
> Restricting fixPermissions to absolute file paths in 4.4 (it was not so
> before) was a breaking change which can be fixed again with the
> suggested patch from Steffen_K (v3), since the used
> t3lib_div::getFileAbsFileName is pretty secure. So the fix should also
> be applied to 4.4.

+1 on reading and testing.

Please apologize for this fail. Actually, I was not aware that is_file() 
(from the previous implementation) can handle relative paths.

Committed attached version together with a unit test to:
* trunk rev. 10019
* 4.4 rev. 10020

Thanks for the pointer
Christian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 15133_v4-trunk.diff
Type: text/x-patch
Size: 2300 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20110110/cddf990b/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 15133_v4-4.4.diff
Type: text/x-patch
Size: 2302 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20110110/cddf990b/attachment-0001.bin>


More information about the TYPO3-team-core mailing list