[TYPO3-core] RFC #16878: Feature: Make t3lib_utility_Client::getBrowserInfo() aware of more operating systems

Jeff Segars jsegars at alumni.rice.edu
Mon Jan 10 21:04:16 CET 2011


On 1/9/11 2:24 PM, Steffen Gebert wrote:
> Hi Andreas,
>
>> Very good solution to be able to use both. I just uploaded patch-v3 to
>> the bugtracker using exactly that – does that work for you?
> please
> * attach patches here (we're all lazy ;-))
> * configure your IDE to *not* add explicitly an empty line after ?>
> * go on with your good work!
>
> I've attached an updated and slightly cleaned up version
> * changed the evaluateConditionCommon to use implode()
> * moved the new OSes up in the check list
> * removed strstr($userAgent, 'Windows NT 5.01') as this is covered by
> check for 5.0)
>
> Need to get away from the PC, so no review for the moment, sorry.
> But unit tests run fine.. rest looks also reasonable.
>
> Kind regards
> Steffen
>

Hey Andy (and Steffen),
Thanks for the update! +1 on reading and testing.

We'll also need a documentation up date for the TSRef when this is 
ready.  Are you able to take care of the docs as well?

Thanks,
Jeff


More information about the TYPO3-team-core mailing list