[TYPO3-core] RFC #17725 Cleanup: Wrong check for FE / BE context in class.t3lib_tstemplate.php

[Rens Admiraal]

Hi Ernesto,

I'll try to make a test situation, but it's hard to post it. Maybe we 
can find some time next week in Berlin to take a look what's going on...

Greetz,
Rens


On 02/24/2011 03:33 PM, Ernesto Baschny [cron IT] wrote:
> Rens Admiraal schrieb am 23.02.2011 19:43:
>> Hi,
>>
>> this is a SVN patch request.
>>
>> Type: Cleanup / no brainer
>>
>> Bugtracker references:
>> http://bugs.typo3.org/view.php?id=17725
>>
>> Branches: 4.5.1
>>
>> I ran into a wrong check for the frontend / backend context in
>> class.t3lib_tstemplate.php. It uses:
>>      if (is_object($GLOBALS['TSFE']))
>>
>> as check instead of:
>>      if (TYPO3_MODE == 'FE')
>>
>
> Any way to reproduce this particular bug? To me its not a "no brainer"
> if I cannot see what will be fixed with this change. :)
>
> E.g. I can imagine that I could have a $GLOBALS['TSFE'] also in BE
> context, and your change would break this situation (just a thought).
>
> Cheers,
> Ernesto
>