[TYPO3-core] RFC: #15359: Speed up / restructure of random byte generator

[Helmut Hummel]

Hi,

Peter Beernink wrote:

> +1 on testing (5.3.2-1ubuntu4.7 and 5.3.0 on Windows)

Thanks for your review.

> A little nitpicking on the reading:
> - The comment '// Windwos php versions below 5.3.4 have a' contains a
> spelling error.

Hm, I don't see it. How should it read?

> Apart from that, also +1 by reading.
>
> Btw, do we still need the @copyright? Apart from the method name I don't
> think there is much left of the original code.

The original code was from Drupal and the idea of "caching" I also got 
from their code. So I'm just fine leaving this note there.

Kind regards,
Helmut

-- 
Helmut Hummel
TYPO3 Security Team Leader

TYPO3 .... inspiring people to share!
Get involved: typo3.org