[TYPO3-core] RFC: #17592: ExtDirect API calls are splitted in single requests and slows down page loading

Steffen Kamper info at sk-typo3.de
Tue Feb 15 11:55:50 CET 2011


Am 15.02.2011 11:21, schrieb Oliver Klee:
> Hi,
>
> very nice! +1 for the approach (though no full review yet). I've noticed
> two nits at a first glance:
>
> Am 15.02.2011 11:02, schrieb Steffen Kamper:
>> +	 * @param array $javascriptNamespaces
>>   	 * @return void
>>   	 */
>> -	public function addExtDirectCode() {
>> +	public function addExtDirectCode($filterNamespaces = array()) {
>
> It looks like the two names (in the @param and in the method
> declaration) don't match. In addition, I propose adding type hinting.
>
>

ah yes, this is a copy&paste error, i will fix the name in phpDoc

I didn't added type hinting, as the function is already in use and can 
be called without parameter.

vg Steffen



More information about the TYPO3-team-core mailing list