[TYPO3-core] RFC: #17592: ExtDirect API calls are splitted in single requests and slows down page loading

Oliver Klee typo3-german-02 at oliverklee.de
Tue Feb 15 11:21:00 CET 2011


Hi,

very nice! +1 for the approach (though no full review yet). I've noticed
two nits at a first glance:

Am 15.02.2011 11:02, schrieb Steffen Kamper:
> +	 * @param array $javascriptNamespaces
>  	 * @return void
>  	 */
> -	public function addExtDirectCode() {
> +	public function addExtDirectCode($filterNamespaces = array()) {

It looks like the two names (in the @param and in the method
declaration) don't match. In addition, I propose adding type hinting.


Oli
-- 
Certified TYPO3 Integrator | TYPO3 Security Team Member


More information about the TYPO3-team-core mailing list