[TYPO3-core] FYI24 #16155: t3lib_db::INSERTquery misses a space when generering the INSERT INTO statement

Ernesto Baschny [cron IT] ernst at cron-it.de
Thu Oct 28 15:14:45 CEST 2010


Hi,

This is a SVN patch, which will be commited in 24h if nobody opposes.

Type: Minor

BT reference: http://bugs.typo3.org/view.php?id=16155

Branches: trunk, TYPO3_4-4, TYPO3_4-3

Problem:
Since RFC #11813 (rev. 6203, 4.3.0 and later), a CGL cleanup on
t3lib_db, the INSERTquery method generates a slightly non-conformant query:

INSERT INTO table(field1, field2) VALUES ($value1, $value2);

note the missing space after the tablename. Correct would be:

INSERT INTO table (field1, field2) VALUES ($value1, $value2);

While newer MySQL versions accept this silently, it might fail on pretty
old MySQL servers.

And it is not that beautiful. :)

Solution:
Add the missing space.


Cheers,
Ernesto

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 16155.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20101028/dc4495aa/attachment.txt>


More information about the TYPO3-team-core mailing list