[TYPO3-core] RFC #15644: Replace magic numbers for shortcut_mode with class constants

Dmitry Dulepov dmitry at typo3.org
Thu Oct 14 08:59:30 CEST 2010


Hi!

Georg Ringer wrote:
> +1 on reading.
> Small side note: Wouldnt it make more sense to use === has it is
> slightly faster too?

Not fast enough to concure database lookups but adds more chaos to the code
because it is not possible to compare $row['xxx'] to a number strictly. SO
it needs a typecast, therefore code readability suffers. This is one of
those cases where strict comparison is not needed at all.

-- 
Dmitry Dulepov
TYPO3 core&security team member
Twitter: http://twitter.com/dmitryd
Read more @ http://dmitry-dulepov.com/


More information about the TYPO3-team-core mailing list