[TYPO3-core] RFC #15928: Replace the current if-construct of stdWrap with real functions and make each of them stdWrap aware

Susanne Moog info at susannemoog.de
Sun Oct 10 19:44:11 CEST 2010


On 10.10.2010 19:39, JoH asenau wrote:
>>>>> One really small, the last chunk with debug - the echo can be
>>>>> removed (it's double as the header of debug use the same)
>>>>
>>>> Attached is Version2 of this patch that takes care of this minor
>>>> issue as well as some other superfluous variables.
>>>> Additionally it adds preCObject, postCObject, prepend and append to
>>>> the functions that should not use nested stdWrap, since they are
>>>> using cObjGetSingle.
>>
>> is there any specific reason why the stdwrap functions don't have a
>> visibility keyword?
> 
> Just forgot them ;-)
> So should it be "public" or "protected"?

I'd vote for public...

>> Other than that:
>>
>> A very light +1 by reading and +1 by testing. Testing means I applied
>> the patch to all my test systems around (4 atm) and all of them still
>> work :-)
> 
> I will provide a testing T3D executing most of the functions at least once together with some basic content elements for the DB stuff.
> It will contain some examples for the nested stdWrap functions as well.
> Guess this will be ready tomorrow evening.
> 
> And I will provide the change in the foreach loop checking for the hooks, that we have been skyping about today as well.
> 
> So just wait for v4 and the T3D and then the +1 might gain more weight ;-)

Forgot about the skype changes, sorry ;) But I'll leave it running for
one or two days on my system so I'll see if further problems arise and I
will use your test t3d then to test again. Patch this big should be
tested a lot :-)


More information about the TYPO3-team-core mailing list