[TYPO3-core] RFC #15511: Bug: fixed some admPanel issues

[Susanne Moog]

On 06.10.2010 11:17, Michael Bürgi wrote:
> This is an SVN patch request.
> 
> Type: Bugfix
> 
> Bugtracker references:
> http://bugs.typo3.org/view.php?id=15511
> 
> Branches:
> TYPO3_4-3 & TYPO3_4-4 & trunk
> 
> Problem:
> This patch addresses the following problems regarding the TS
> configuration of the adminPanel:
> 
> - "override.preview = 1" being required to activate the preview if the
> adminPanel is hidden. Unfortunately this undocumented setting turns on
> all preview settings.
> 
> - override.* settings can only override if they evaluate to true. This
> means that you could never turn features off, only on: e.g.
> override.preview.showHiddenPages = 0 is ignored!
> 
> The combination of both problems make it nearly impossible to configure
> the adminPanel for certain configurations. see bug tracker for more
> information.
> 
> Solution:
> - "override.preview = 1" is no longer required to activate the preview
> if the adminPanel is hidden.
> - The patch enables override.* settings to override even if they
> evaluate to false (used for turning features off e.g.)
> 
> 
> Notes:
> I've put quite a lot of time into this issue. Please have a look at it.
> The Bug tracker issue contains some additional problems which are not
> addressed by this patch.

+1 by reading and testing and thanks for that bug report it is fantastic :-)

Two small things about your mails:
Could you try to send your patches as plaintext attachements? (Currently
they are defined as "application/octet-stream" which makes it impossible
to read them inline)
And could you make your patches relative to the typo3 root (like you
already do but without the slash at the path beginning)?

Thank you again for contributing,

Susanne