[TYPO3-core] RFC #14303: t3lib_compressor causes filemtime errors on files in fileadmin directory

Rens Admiraal renst3 at rensnel.nl
Mon Nov 29 12:22:47 CET 2010


Hi,

This is a SVN patch request.

Type: Bugfix / Clean up

BT reference: Seems to be related / same issue: 
http://bugs.typo3.org/view.php?id=14303

Problem:
The t3lib_compressor class causes errors due to incorrect paths. In our 
case this happened in an extension which created an instance of the 
rtehtmlarea RTE, which automatically loads the RTE.default.contentCSS 
property from TSConfig, but there was also a bug report (#14303) which 
mentioned the same error. This caused t3lib_compressor to work with the 
following path:
min/templates/....
which is caused by the following (quite dirty) code:
substr($filename, strlen($GLOBALS['BACK_PATH']))

Solution:
Check the location of the file being compressed

How to test:
No specific test besides validating if CSS is still loaded in the 
backend, for example in the following screens:
- Backend modules
- Login screen

Additional information:
By using the old code as default return and checking for file existence 
this code should be backwards compatible.

Greetz,
Rens
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 14303-t3lib_compressor.patch
Type: text/x-patch
Size: 3297 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20101129/bccee350/attachment.bin>


More information about the TYPO3-team-core mailing list