[TYPO3-core] RFC #16107: Bugfix - listNum = 0 not working anymore due to stdWrap changes

Jeff Segars jsegars at alumni.rice.edu
Tue Nov 16 19:06:10 CET 2010


On 11/7/10 10:31 PM, Jeff Segars wrote:
> Attached v4 applies cleanly to trunk and adds one naming cleanup:
> $stdWrapDisabledFunctions is now $stdWrapDisabledFunctionTypes
>
> One thing I notice is that the list of function types is mixed case.
> cObject, getText etc are camel-cased whereas functioname, fieldname, etc
> are lower cased. It looks like this follows the conventions from TSRef,
> but transforms function-name to function name. Would it make sense to
> keep be consistent and camel case everything or follow TSRef directly?
>
> Also, would the function types potentially be useful in other places and
> if so would class constants be a better choice rather than strings?
>
> Other than those two comments, +1 on reading with testing to follow
> tomorrow.
>
> Thanks,
> Jeff

+1 on testing.  Joey, any feedback on my comments?

Thanks,
Jeff


More information about the TYPO3-team-core mailing list