[TYPO3-core] RFC #13750: Bug: Several GIFBUILDER features broken for IM4, IM6 and GM

Ernesto Baschny [cron IT] ernst at cron-it.de
Fri Nov 12 21:17:29 CET 2010


Steffen Gebert schrieb am 12.11.2010 20:58:
>> Latest patch is your v4 for which you wrote "this is completely untested
>> since I have no *nix installation with safe_mode active".
>>
>> So what do you expect from your fellow reviewing friends?
> I thinks he expects testing with safe_mode (was the mail from 2.11.).
> At least I tagged this mail as "review ASAP".

So with the patch v4 the bug under Windows is definitively fixed? Is
this already "proved"? If this is the case, we just want to make sure it
doesn't break other situations (Linux and safe_mode)?

I applied your test cases (changed filename "testCase" => "Test") and it
does fail before and after applying the patch:

"
The exploded command does not match the expected Failed asserting that
Array ( [0] => /opt/local/bin/gm.exe [1] => convert [2] => +profile [3]
=> '*' [4] => -geometry [5] => 170x136! [6] => -negate [7] =>
"C:/Users/Someuser.Domain/Documents/Htdocs/typo3temp/temp/61401f5c16c63d58e1d92e8a2449f2fe_maskNT.gif"[0]
"C:/Users/Someuser.Domain/Documents/Htdocs/typo3temp/temp/61401f5c16c63d58e1d92e8a2449f2fe_maskNT.gif"
)

is equal to

Array ( [0] => /opt/local/bin/gm.exe [1] => convert [2] => +profile [3]
=> '*' [4] => -geometry [5] => 170x136! [6] => -negate [7] =>
"C:/Users/Someuser.Domain/Documents/Htdocs/typo3temp/temp/61401f5c16c63d58e1d92e8a2449f2fe_maskNT.gif"[0]
[8] =>
"C:/Users/Someuser.Domain/Documents/Htdocs/typo3temp/temp/61401f5c16c63d58e1d92e8a2449f2fe_maskNT.gif"
) .

"

the only difference I see is the missing [8] array key in the expected
value. Is the test case bogus, the patch buggy or my setup buggy? :)

Cheers,
Ernesto


More information about the TYPO3-team-core mailing list