[TYPO3-core] RFC #4203: Workspace DB / filemounts should narrow down the users' mounts

Jeff Segars jsegars at alumni.rice.edu
Mon Nov 8 22:30:59 CET 2010


On 9/17/10 10:56 AM, Benjamin Mack wrote:
> Hey all,
>
> this is a SVN patch request.
>
> Branches: trunk
>
> Type: Cleanup / Feature
>
> BT reference: http://bugs.typo3.org/view.php?id=4203
>
> Problem: Right now, handling of filemounts / db mounts in the workspace
> process in not streamlined. In a workspace record, you can select DB-
> and filemounts that should be allowed in this workspace. But this should
> also fit with the users existing permissions. Thus, the workspaces team
> decided on having the mountpoint selections in the workspace record as a
> "filter" to additionally narrow down the DB mountpoints the user already
> has. (see
> http://news.typo3.org/news/article/bringing-workspaces-up-to-speed/)
>
> The patch does exactly that.
>
> All the best,
> Benni.

2 comments from reading....

* There's a typo in variable naming when the unneeded filemounts are 
removed.  The variable is set as $md5 and then read as $md5hash.

* In workspaceList_getFileMountPoints, 
$GLOBALS['BE_USER']->groupData['filemounts'] is assumed to be a 
comma-separated list but is actually an array, which ends up causing 
errors when cleanIntList is called a few lines later.

Other than that, everything looks good on reading.  Further testing to 
follow

Thanks,
Jeff


More information about the TYPO3-team-core mailing list