[TYPO3-core] RFC #16252: Apply "bookmarks" naming to UserTS options

[Susanne Moog]

On 06.11.2010 12:15, Steffen Kamper wrote:
> Hi,
> 
> where is the rename of alt_shortcut to alt_bookmark and
> class.shortcutmenu.php to class.bookmarkmenu.php? :D
> 
> +        $shortCutGroups =
> $BE_USER->getTSConfigProp('options.shortcutGroups');
> +        if ($shortCutGroups !== NULL) {
> +            t3lib_div::deprecationLog('options.shortcutGroups - since
> TYPO3 4.5, will be removed in TYPO3 4.7 - use options.bookmarkGroups
> instead');
> +        }
> +        $bookmarkGroups =
> $BE_USER->getTSConfigProp('options.bookmarkGroups');
> +        if ($bookmarkGroups !== NULL) {
> +            $shortCutGroups = $bookmarkGroups;
> +        }
> 
> you deprecate this setting if it's used but ignore the setting. I
> suggest: use it and log deprecated. Same happens at other place in
> class.shortcutmenu.php too.

That's what we are doing:

+		$shortCutGroups = $BE_USER->getTSConfigProp('options.shortcutGroups');
+		if ($shortCutGroups !== NULL) {
+			t3lib_div::deprecationLog('options.shortcutGroups - since TYPO3 4.5,
will be removed in TYPO3 4.7 - use options.bookmarkGroups instead');
+		}
+		$bookmarkGroups = $BE_USER->getTSConfigProp('options.bookmarkGroups');
+		if ($bookmarkGroups !== NULL) {
+			$shortCutGroups = $bookmarkGroups;
+		}
+		if (is_array($shortCutGroups) && count($shortCutGroups))	{

the newer setting takes precedence but if the newer setting isn't used
the old one still is (because we go on using $shortCutGroups) - or
didn't I get you?

Susanne

-- 
What's worth the price is always worth the fight
Every second counts 'cause there's no second try

TYPO3 Core Team Member