[TYPO3-core] RFC #16252: Apply "bookmarks" naming to UserTS options

Steffen Kamper info at sk-typo3.de
Sat Nov 6 12:15:59 CET 2010


Hi,

where is the rename of alt_shortcut to alt_bookmark and 
class.shortcutmenu.php to class.bookmarkmenu.php? :D

+		$shortCutGroups = $BE_USER->getTSConfigProp('options.shortcutGroups');
+		if ($shortCutGroups !== NULL) {
+			t3lib_div::deprecationLog('options.shortcutGroups - since TYPO3 4.5, 
will be removed in TYPO3 4.7 - use options.bookmarkGroups instead');
+		}
+		$bookmarkGroups = $BE_USER->getTSConfigProp('options.bookmarkGroups');
+		if ($bookmarkGroups !== NULL) {
+			$shortCutGroups = $bookmarkGroups;
+		}

you deprecate this setting if it's used but ignore the setting. I 
suggest: use it and log deprecated. Same happens at other place in 
class.shortcutmenu.php too.

Also you added at several places
// "Shortcuts" have been renamed to "Bookmarks"
Please add also: Remove following line in version ... So it will be 
easier when removing shortcuts completely

Other than that +1 by reading and testing.

vg Steffen


More information about the TYPO3-team-core mailing list