[TYPO3-core] RFC: #16136: Change behaviour of check for allowed file extensions -> make it possible to really restrict to certain file extensions for filemounts

[Susanne Moog]

On 01.11.2010 23:51, Steffen Gebert wrote:
>> Bugtracker reference: http://bugs.typo3.org/view.php?id=16136
>>
>> Branches: trunk
>>
>> With the settings
>> $TYPO3_CONF_VARS['BE']['fileExtensions']['webspace']['allow'] (and
>> …['ftpspace']) you ought to be able to restrict what kind of filetypes
>> can be used in the filelist module.
> 
> Hi Andreas,
> 
> thanks for your patch!
> 
> I had a look at it and, of course, you're right. The current behavior is
> a bit weird :)
> 
> Reading your patch, I would say that abandoning early returns makes the
> function hard to read.
> I reworked it a bit, according to your Unit tests, I made no fault :)
> 
> What do you think?
> Of course, we could make a huge if-else-elseif-if-else construct, but
> IMHO criticism of early returns is more regarding returns inside complex
> if-constructs.
> 
> +1 by reading and testing

+1 by reading and testing,

Susanne


-- 
What's worth the price is always worth the fight
Every second counts 'cause there's no second try

TYPO3 Core Team Member