[TYPO3-core] RFC: #16136: Change behaviour of check for allowed file extensions -> make it possible to really restrict to certain file extensions for filemounts

Andreas Kiessling kiessling at pluspol.info
Tue Nov 2 00:44:38 CET 2010


Hi Steffen,

> Reading your patch, I would say that abandoning early returns makes the
> function hard to read.
> I reworked it a bit, according to your Unit tests, I made no fault :)
>
> What do you think?
> Of course, we could make a huge if-else-elseif-if-else construct, but
> IMHO criticism of early returns is more regarding returns inside complex
> if-constructs.
>
> +1 by reading and testing
>

I probably overdid the "optimizing" there and your version looks indeed 
much better.

+1 by reading and testing on v3

Regards and thanks,
Andreas


More information about the TYPO3-team-core mailing list