[TYPO3-core] RFC #14342: t3lib_compressor also rewrites data URIs

Susanne Moog info at susannemoog.de
Fri May 28 10:38:00 CEST 2010


On 20.05.2010 21:00, Steffen Gebert wrote:
> Am 20.05.2010, 20:49 Uhr, schrieb JoH asenau <info at cybercraft.de>:
> 
>>>>> OK guys, you are right - so I will change this to a +1 if we can be
>>>>> sure that this kind of URL which can be used to get data from i.e.
>>>>> a htaccess protected page, will be treated correctly as well:
>>>>> data:1234 at whatever.domain.tld/some/path/to/my/file.jpg
>>>>>
>>>> good point - even if i think that noone will put passwords to css I
>>>> think it is allowed... Think Steffen kann recheck this after he
>>>> returned from sports.
>>>
>>> Isn't a ":" a good sign for a string being not a file name?
>>
>> As you can see from my example there is a ":" in the URL pointing to a
>> file
>> name.
>> Since this is the only case I can imagine it would be enough to check for
>> ":" in absence of "@"
> 
> But we mustn't rewrite this url, as it's an absolute one..
> So I see no reason against checking for presence of ":" and then *not*
> to change the URI.
> 
> Patch attached

+1 by reading and testing

susanne


More information about the TYPO3-team-core mailing list