[TYPO3-core] RFC #14342: t3lib_compressor also rewrites data URIs

Steffen Gebert steffen at steffen-gebert.de
Thu May 20 21:00:49 CEST 2010


Am 20.05.2010, 20:49 Uhr, schrieb JoH asenau <info at cybercraft.de>:

>>>> OK guys, you are right - so I will change this to a +1 if we can be
>>>> sure that this kind of URL which can be used to get data from i.e.
>>>> a htaccess protected page, will be treated correctly as well:
>>>> data:1234 at whatever.domain.tld/some/path/to/my/file.jpg
>>>>
>>> good point - even if i think that noone will put passwords to css I
>>> think it is allowed... Think Steffen kann recheck this after he
>>> returned from sports.
>>
>> Isn't a ":" a good sign for a string being not a file name?
>
> As you can see from my example there is a ":" in the URL pointing to a  
> file
> name.
> Since this is the only case I can imagine it would be enough to check for
> ":" in absence of "@"

But we mustn't rewrite this url, as it's an absolute one..
So I see no reason against checking for presence of ":" and then *not* to  
change the URI.

Patch attached

Steffen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 14342_v2.diff
Type: text/x-diff
Size: 972 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100520/5ca83078/attachment.diff>


More information about the TYPO3-team-core mailing list