[TYPO3-core] RFC #14387: Remove the feature "Enable extensions without review (basic security check)" from EM

Steffen Gebert steffen at steffen-gebert.de
Fri May 21 09:51:53 CEST 2010


Am 21.05.2010, 09:19 Uhr, schrieb Lars Houmark <lars at houmark.com>:

>>> + // Show extensions without a review or that have passed a review,
>>> but not insecure extensions
>>> + $where .= ' AND reviewstate >= 0';
>> Why not just leave the reviewstate out of WHERE?
>
> Because "-1" in the database, is extensions (in the version) marked  
> insecure, meaning we DO NOT want to show them ;)
Good catch - should have read the comment :D

> Thinking of that, they are not much of help, and while removing code and  
> this feature in particular it makes sense to remove that code also,  
> doesn't it?
Absolutely fine for me

>>> $GLOBALS['LANG']->getLL('list_or_look_up_extensions') . ':</label>
>> Can't you include the ":" in the LL?
>
> I actually chatted with Dmitry about this, and he would personally like  
> it the current way, so I guess him being a core dev he has more right to  
> decide where it is, right? :P If another core thinks the same as you, I  
> guess this can be changed on commit, okay?
fine for me.. was just an idea, as I would say the : belongs to the label

Steffen


More information about the TYPO3-team-core mailing list