[TYPO3-core] RFC: #13670: Performance optimization: change while(list() to foreach()

Steffen Gebert steffen at steffen-gebert.de
Tue May 18 00:39:31 CEST 2010


Am 17.05.2010, 19:45 Uhr, schrieb Lars Houmark <lars at houmark.com>:

> Hi Steffen,
>
> Steffen Kamper wrote:
>> these errors astonish me - hopefully it was the last one.
>
> It wasn't. After seeing all of these follow-ups, I got a bit concerned
> and decided to read the v5 patch from Steffen. Yes boring, but I found
> that this part of the patch is breaking the fe_adminLib.inc file
> completely due to syntax error:
>

Ouch.. reviewing by reading was very hard.. but it should have been done  
more carfully than just scrolling through - sorry.

I just did a `php -l` over all .php files, the one in t3lib_querygenerator  
was the only parse error I could find this way.

Steffen


More information about the TYPO3-team-core mailing list