[TYPO3-core] RFC #14324: Feature: Add spriteGeneratorAPI to support the new sprite-icon-api

[Steffen Ritter]

Am 08.05.2010 01:12, schrieb Steffen Kamper:
> Hi Steffen,
>
> i took a first look to the patch and here are some remarks, could you
> update the patch to these comments?
>
> * please use CGL (missing spaces (function params, t3lib_spriteManager),
> "AS", closing strings with wrong indentation, missing phpDocs for class
> vars, missing phpDocs for functions (eg __constructor)
>
> * we always use lower case filenames (class.t3lib_spriteManager.php)
>
> * in t3lib_spriteManager line 119 - $cacheFile was never defined
>
> I will do a deeper review soon.
>
> vg Steffen
Attached is version 3 which
  - tries to be more CGL compliant...
  - Warnings came from missing check for existing tempDir, now added in 
constructor.
  - Improoved doc-comments
  - exchanged wrong var name $cacheFile with class-var

regards

Steffen
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: spriteManager_v3.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100510/048a3509/attachment.asc>