[TYPO3-core] RFC #14295: Recycler and tcemain->process_cmdmap cannot undelete some records

[Lars Houmark]

Hi,

This is a SVN patch request.

Type: Bugfix

BT reference: http://bugs.typo3.org/view.php?id=14295

Branches: trunk, 4.3

Problem: Some records (like be_users) with pid of 0 cannot be undeleted 
by the tcemain->process_cmdmap undelete method. Since the recycler uses 
this instance to undelete records, it is also affected.

Solution: Improve the check for isRecordUndeletable in tcemain.

How to test:

- Create a be_user and delete it
- Use the recycler to locate the be_user (notice is has PID=0) and try 
to undelete
- It fails
- Apply the patch
- Try to undelete the be_user again, and see that it is now correctly 
undeleted

Notes: The pid check of the isRecordUndeletable function seems to be 
simply too strict, and since a page with the pid of 0 has no parent page 
to check if is deleted, it can simply allow the undelete process to move on.

The patch should apply both to trunk and the 4.3 branch with a minor offset.

--
Lars Houmark

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 14295.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100504/31e8b997/attachment.txt>