[TYPO3-core] RFC: #9581: clean up t3lib_exec

[Felix Oertel]

Hi,

not yet ready ;-)

line 319 - 320:

$pathSetup = implode("\n", t3lib_div::trimExplode(',', 
$GLOBALS['SYS']['binSetup'], 1));
$pathSetup = t3lib_div::trimExplode("\n", $pathSetup, 1);

There is "['TYPO3_CONF_VARS']" missing. Anyway I don't like this hole 
explode(implode(explode()))-stuff ... why not:

preg_split('/[\n,]+/', $GLOBALS['TYPO3_CONF_VARS']['SYS']['binSetup']);
(thanks to steffenk ;-)

Additionally there were some smaller CGL-issues (mainly missing space in 
"foreach(" and in declaration-parameters).

I attached a cleaned patch considering this stuff ...

Regards, foertel


Am 26.03.10 12:53, schrieb Francois Suter:
> Hi,
>
>> * use PHP5 function static declaration
>> * use static member variables instead of globals
>> * reformat according to CGL
>
> Thanks to Felix for refreshing this issue.
>
> Attached is v8 of the patch. It adds some forgotten CGL cleanups or some
> new ones from more recent CGL updates (e.g. booleans should be uppercase).
>
> Most importantly I have removed from the patch a revert of a previous
> patch, which seems abusive to me.
>
> I'm talking about the following lines:
>
> + if (TYPO3_OS=='WIN') {
> +// TODO: add the most common paths for WIN
> + $sysPathArr = array_merge($sysPathArr, array (
> + 'C:/Programs' => 'C:/Programs',
> + 'C:/Perl/bin' => 'C:/Perl/bin',
> + ));
> + } else { // UNIX
>
> which reintroduced wrong Windows exec paths that were purposefully
> removed in rev 6521, related to: http://bugs.typo3.org/view.php?id=12547
>
> I tested by checking the "Installed services" report which contains
> check of all available executable paths and found it to be working like
> before.
>
> I would like to have fresh votes on this patch.
>
> Cheers
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bug_9581_v9.diff
Type: text/x-patch
Size: 14070 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100326/f4f2843d/attachment-0001.bin>