[TYPO3-core] FC: #13799: [Feature] ExtJS driven fading in/out Flashmessages

Stefan Galinski stefan.galinski at gmail.com
Tue Mar 16 02:47:58 CET 2010


Steffen Kamper wrote:

> Hi,
> 
> Stefan Galinski schrieb:
>> Steffen Kamper wrote:
>> 
>>> Steffen Kamper schrieb:
>>>> Hi,
>>>>
>>>> here is v3 where i renamed the variable names as olly suggested
>>>>
>>>> vg Steffen
>> 
>> +1 by reading if you fix the CGL issues (and testing by testing the new
>> extension manager :-)
>> 
> 
> which CGL issues?
> 
> vg Steffen

Hi Steffen,

I know that the CGL was designed for PHP and not JS, but if we apply the 
rules nonetheless, we would get the following...

* usage of double quotes
  pause(duration).ghost("t", {remove:true});
  
* usage of true instead of TRUE

* missing spaces for better readability
  {id:'msg-div',style:'position:absolute;z-index:10000'}
  if(!messageContainer){
  parentContainer){

--
Stefan Galinski



More information about the TYPO3-team-core mailing list