[TYPO3-core] RFC #13729: Cleanup: t3lib_div CGL Cleanup: Missing spaces around string concatenator

Sebastian Gebhard sebastiangebhard at hoch2.de
Wed Mar 3 15:44:00 CET 2010


Am 03.03.10 15:36, schrieb Steffen Kamper:
> Hi,
>
> you still missed spaces.
>
> Examples:
> $newFile = substr($theFile,0,-4) . '.gif';
> return intval((int)$verParts[0] .
> str_pad((int)$verParts[1],3,'0',STR_PAD_LEFT) .
> str_pad((int)$verParts[2],3,'0',STR_PAD_LEFT));
> $string = substr($string,0,$valueLenO) .
> self::calcParenthesis(substr($string,$valueLenO+1));
>
> a.s.o.
>
> vg Steffen

As I said, this RFC only focuses on spaces around string concatenator 
(the dot operator).
Adding spaces after comma and around other operators whould make this 
patch 2 or 3 times longer.
As a next step I plan to hand in a patch which
- replaces tabstops with spaces before opening curly braces
- adds spaces after comma
- adds spaces around the operators: = .= + - *


More information about the TYPO3-team-core mailing list