[TYPO3-core] RFC #13729: Cleanup: t3lib_div CGL Cleanup: Missing spaces around string concatenator

[Ernesto Baschny [cron IT]]

Hi,

haven't checked your patch, but your attachment says:

Content-Type: multipart/appledouble;
	boundary="------------ad010700010908000800030106";
	x-mac-type="0"; 	x-mac-creator="0";
	 name="13729_v1.diff"

It would be cool if your mail client could stick to text/plain or
text/x-patch, as other clients would be able to display it "inline" (and
potentially with syntax highlighting, as for example with TB extension
"Colored diffs").

Cheers,
Ernesto

Sebastian Gebhard schrieb am 03.03.2010 14:31:
> This is an SVN patch request.
> 
> Type: Cleanup
> 
> Bugtracker references: http://bugs.typo3.org/view.php?id=13729
> 
> Branches: trunk
> 
> Problem:
> t3lib_div does absolutely not match the current CGL. This RFC focuses
> only on one particular rule of CGL: "String concatenation operator must
> be surrounded by spaces".
> 
> Solution:
> Add missing spaces
> 
> Notes:
> This RFC intentionally ignores other violations of the CGL, because this
> would be too much for one RFC. So the modified lines still contain
> violations like missing spaces after comma and so on.
> I'd like to send in additional patches like this one for other violations.
> 
> I hope I got all missing spaces and did not introduce bugs by inserting
> spaces at wrong places (e.g. inside strings).
> 
> This patch was created partly-automated and I checked the code by hand
> twice. Also I tested it with a copy of a TYPO3-Website where everything
> went fine.
> 
> But, as you know, t3lib_div affects all areas of TYPO3 so, it's still
> possible that I introduced a bug somewhere.
> Please take the time and read every line of the patch and try out
> different functions of TYPO3 after applying it.
> 
> Kind regards,
> Sebastian Gebhard