[TYPO3-core] RFC #13729: Cleanup: t3lib_div CGL Cleanup: Missing spaces around string concatenator

Sebastian Gebhard sebastiangebhard at hoch2.de
Wed Mar 3 14:31:16 CET 2010


This is an SVN patch request.

Type: Cleanup

Bugtracker references: http://bugs.typo3.org/view.php?id=13729

Branches: trunk

Problem:
t3lib_div does absolutely not match the current CGL. This RFC focuses 
only on one particular rule of CGL: "String concatenation operator must 
be surrounded by spaces".

Solution:
Add missing spaces

Notes:
This RFC intentionally ignores other violations of the CGL, because this 
would be too much for one RFC. So the modified lines still contain 
violations like missing spaces after comma and so on.
I'd like to send in additional patches like this one for other violations.

I hope I got all missing spaces and did not introduce bugs by inserting 
spaces at wrong places (e.g. inside strings).

This patch was created partly-automated and I checked the code by hand 
twice. Also I tested it with a copy of a TYPO3-Website where everything 
went fine.

But, as you know, t3lib_div affects all areas of TYPO3 so, it's still 
possible that I introduced a bug somewhere.
Please take the time and read every line of the patch and try out 
different functions of TYPO3 after applying it.

Kind regards,
Sebastian Gebhard
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/applefile
Size: 1485 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100303/5e2a8bc0/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 13729_v1.diff
Type: application/octet-stream
Size: 60885 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100303/5e2a8bc0/attachment-0001.obj>


More information about the TYPO3-team-core mailing list