[TYPO3-core] RFC #8778: Feature: Add possibility to disable TYPO3 draft workspace by localconf.php configuration

Steffen Gebert steffen at steffen-gebert.de
Fri Jun 4 12:53:41 CEST 2010


> Thank you also for your feedback for the diff. I've corrected it and
> send the updated diff with this mail.

Hi Sonja,

sorry for nagging again, but it's still not correct.

>  		$retVal = FALSE;
> -
> +		
> +			// Show draft workspace only if enabled in version extension
You're removing an empty line and add one with two tab characters. That's  
not good.

> +					}+				}
> +			}+		}
Most of the closing brackets have a trainling space.

> if(t3lib_extMgm:
> if(!$version_
> if((string)
space after "if", please.

P.S: Enabling whitespace characters in your IDE helps to find some of the  
issues ;)
And you could also configure it to remove trailing whitespaces at saving  
(which sometimes leads to unwanted changes in lines, which aren't modified  
by your patch (aka. whitespace cleanup)).


More information about the TYPO3-team-core mailing list