[TYPO3-core] RFC #12322: cHash is generated when no parameters are given

[Dmitry Dulepov]

Hi!

This is SVN patch request.

Type: bug

BT reference: http://bugs.typo3.org/view.php?id=12322

Branches: 4.3, 4.4, trunk

Problem: cHash is always calculated if typolink configuration contains
'useCacheHash', even if a list of parameters is empty. This is bad for
caches and for RealURL.

Solution: the attached patch will change typolink() to create cHash only if
parameters do exist.

How to reproduce:

10 = TEXT
10.value = Link
10.typolink {
	parameter.data = TSFE:id
	additionalParams = &
	useCacheHash = 1
}

The example above is stupid but this is what can come from extensions
sometimes. This would create lots of identical cHashes for various pages
and RealURL cache will be flooded with them. RealURL cannot solve it
because it must obey when cHash is provided by the caller. So it has to be
solved on the typolink level. And it is generally good to have clean URLs ;)

-- 
Dmitry Dulepov
TYPO3 core&security teams member
Twitter: http://twitter.com/dmitryd
Read more @ http://dmitry-dulepov.com/
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 12322.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100713/131faae8/attachment.txt>