[TYPO3-core] RFC #12679: Pagemodule don't show clipboard paste icon when there is no content

Reinhard Führicht rf at typoheads.at
Tue Jul 13 09:19:08 CEST 2010


Am 2010-07-13 03:43, schrieb Andreas Wolf:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi Reinhard,
>
> Am 12.07.10 16:25, schrieb Reinhard Führicht:
>> Am 2010-07-12 15:52, schrieb Oliver Klee:
>>> - Please use "protected" instead of "var".
>>> - Please don't set $dblist->pObj from the outside, but please use a
>>> setter instead.
>
> just one small remark - please don't name the setter setPObj. I know
> that the core is cluttered with these cryptic cObj and pObj and xObj
> variables, but at least when introducing new variables and functions we
> should try to avoid this naming. PObj always makes me think at least
> five seconds if it's "page" or "parent" in this context...
>
> Regards
>
> Andreas
>
> P.S.: I didn't read the patch until now, maybe I'll manage to do so in
> the next few days.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (Darwin)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkw7xLsACgkQHWtXp155bP+/eQCghysexFsJzn5NfSjicJU3daMY
> mmQAmQHn5hlt9Lvu6BEihV0sQOkAB/7S
> =XxXM
> -----END PGP SIGNATURE-----


Version 7 renames $pObj to $parentObject (and the setter according).

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 12679_v7.diff
Type: text/x-patch
Size: 12010 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100713/224e9097/attachment.bin>


More information about the TYPO3-team-core mailing list