[TYPO3-core] RFC # 15029: Testcase for t3lib_div::isFirstPartOfStr is missing.
Steffen Kamper
info at sk-typo3.de
Wed Jul 7 16:18:22 CEST 2010
Hi,
Nikolas Hagelstein schrieb:
>
> Ok, this is v2. I moved all special cases over to a dataprovider.
> I am a little bit concerned about :
>
> 'null/zero' => array(NULL, 0),
> 'empty string/zero' => array('', 0),
>
> Both are returning true...this is indeed what I expected by reading the
> functions source but I would say that is not intent behavior.
>
this is exactly what tests are good for ;) It was never tested this way,
so for any change on function the tests are good.
Imho both should return false because no string, so let them fail ;)
vg Steffen
More information about the TYPO3-team-core
mailing list