[TYPO3-core] RFC #15021: Cleanup: replace calls to t3lib_div::testInt with calls to is_int, mark t3lib_div:testInt as deprecated

Michiel Roos [netcreators] michiel at netcreators.com
Wed Jul 7 10:09:55 CEST 2010


On 7/7/10 9:21 AM, Dmitry Dulepov wrote:
> Hi!
> 
> Michiel Roos [netcreators] wrote:
>> V2 adds: self::logDeprecatedFunction(); to the testInt function.
> 
> -1 for the same reason as previous patch: is_int() does not do the same as
> t3lib_div::testInt():
> 
> t3lib_div::testInt('5') returns true
> is_int('5') returns false
> 

Agreed,

Please find attached a testcase that checks the results.

But!

:-)

I think a review of all the cases where the function is called is in
order. I don't think all the places where it is called actually feed
string data into the function.

I may go over all the calls some day.

-- 
Met vriendelijke groet / Warm regards,

Michiel Roos
Chief Technical Officer
Netcreators: Open Source, Open Minds, Open People
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 15020_testInt_test_v2.php
Type: text/php
Size: 2188 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100707/b09df22c/attachment.bin>


More information about the TYPO3-team-core mailing list