[TYPO3-core] RFC: #13201: [Bugfix] Use same install tool check for reports as used in About module

[Moreno Feltscher]

This is an SVN patch request.

Type: Bugfix

Bugtracker references:
http://bugs.typo3.org/view.php?id=13201

Branches:
TYPO3_4-3, trunk

Problem:
At the moment the report module checks for install tool file existence. If  
the file exists a warning is shown. Concerning to this behavior the  
warning text is wrong because it states that the install tool is  
permanently enabled (which is only true if the install tool file contains  
the string "KEEP_FILE").

Solution:
Use same install tool check as we already use in the "About" module.

Notes:
We already had a huge discussion about the install tool file handling for  
RFC #11731 [1] on this mailing list [2] and we decided to just check  
whether the KEEP_FILE string (which permanently unlocks the install tool)  
exists or not.
Additionally I'm working on a proper install tool file check solution for  
upcoming releases.. stay tuned.

[1] http://bugs.typo3.org/view.php?id=11731
[2]  
http://lists.typo3.org/pipermail/typo3-team-core/2009-August/028886.html


Cheers
Moreno



Index:  
typo3/sysext/reports/reports/status/class.tx_reports_reports_status_securitystatus.php
---  
typo3/sysext/reports/reports/status/class.tx_reports_reports_status_securitystatus.php  
Base (BASE)
+++  
typo3/sysext/reports/reports/status/class.tx_reports_reports_status_securitystatus.php  
Locally Modified (Based On LOCAL)
@@ -248,7 +248,8 @@

  		$enableInstallToolFileExists = is_file($enableInstallToolFile);

-		if ($enableInstallToolFileExists || ($enableInstallToolFileExists &&  
trim(file_get_contents($enableInstallToolFile)) === 'KEEP_FILE')) {
\ No newline at end of file
+			// Check whether the file ENABLE_INSTALL_TOOL contains the string  
"KEEP_FILE" which permanently unlocks the install tool
+		if ($enableInstallToolFileExists &&  
trim(file_get_contents($enableInstallToolFile)) === 'KEEP_FILE') {
\ No newline at end of file
  			$value    = $GLOBALS['LANG']->getLL('status_enabled');
  			$severity = tx_reports_reports_status_Status::WARNING;

-------------- next part --------------
A non-text attachment was scrubbed...
Name: bug_13201.diff
Type: application/octet-stream
Size: 960 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100110/6d7b9329/attachment.obj>