[TYPO3-core] RFC #13199: Cleanup: fileadminDir is hardcoded in several places

Susanne Moog typo3 at susannemoog.de
Sun Jan 10 19:24:40 CET 2010


Hey Steffen,

Am 10.01.2010 18:16, schrieb Steffen Gebert:
> Am 10.01.2010, 17:17 Uhr, schrieb Susanne Moog <typo3 at susannemoog.de>:
> 
>> This is an SVN patch request.
>>
>> Type: Cleanup
>>
>> Bugtracker references:
>> http://bugs.typo3.org/view.php?id=13199
>>
>> Branches:
>> trunk
>>
>> Problem:
>> The fileadminDir is hardcoded in several places although the
>> configuration variable for it should be used.
>>
>> Solution:
>> I did a search through the whole core and replaced all hardcoded
>> occurrences. Together with the patch for 0005716 all hardcoded
>> fileadmins are replaced.
> 
> Hi Susanne,
> 
> are you sure, this works?
> 
> 
> - if ($onlineResourceFlag<=0 && substr($fI['path'],0,10)=='fileadmin/')
> + if ($onlineResourceFlag <= 0 && substr($fI['path'], 0, 10) ==
> $GLOBALS['TYPO3_CONF_VARS']['BE']['fileadminDir'])
> 
> The substr($str, 0, 10) looks too hardcoded for me..

you are totally right. Find attached a new version.

Best regards,

Susanne

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 13199_fileadminDirv2.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100110/d34a0ecf/attachment.asc>


More information about the TYPO3-team-core mailing list