[TYPO3-core] RFC #13199: Cleanup: fileadminDir is hardcoded in several places

Steffen Gebert steffen at steffen-gebert.de
Sun Jan 10 18:16:32 CET 2010


Am 10.01.2010, 17:17 Uhr, schrieb Susanne Moog <typo3 at susannemoog.de>:

> This is an SVN patch request.
>
> Type: Cleanup
>
> Bugtracker references:
> http://bugs.typo3.org/view.php?id=13199
>
> Branches:
> trunk
>
> Problem:
> The fileadminDir is hardcoded in several places although the
> configuration variable for it should be used.
>
> Solution:
> I did a search through the whole core and replaced all hardcoded
> occurrences. Together with the patch for 0005716 all hardcoded
> fileadmins are replaced.

Hi Susanne,

are you sure, this works?


- if ($onlineResourceFlag<=0 && substr($fI['path'],0,10)=='fileadmin/')
+ if ($onlineResourceFlag <= 0 && substr($fI['path'], 0, 10) ==  
$GLOBALS['TYPO3_CONF_VARS']['BE']['fileadminDir'])

The substr($str, 0, 10) looks too hardcoded for me..

Steffen


More information about the TYPO3-team-core mailing list