[TYPO3-core] RFC #13435: t3lib_htmlmail -> from_name in FROM header not quoted

Steffen Kamper ks at dislabs.de
Sat Feb 27 14:09:16 CET 2010


Hi,

Stefan Galinski schrieb:
> Benjamin Mack wrote:
> 
>> Hey Stefan,
>>
>> cool. thank you.
>>
>> But I just thought of another question... ;-) (nothing to fix, just to
>> think about). Shouldn't we always quote, and remove double-quotes at any
>> time the from name and reply-to name (if it's non-empty)? Any reason
>> *not* to escape this all the time?
>>
>> Otherwise we find another symbol that needs to be checked, and it's a
>> leak we have to fix again and again...
>>
>> All the best,
>> Benni.
> 
> Sure, that was my first thought (see version 1 of the patch) too. Steffen 
> changed that behaviour in version 2 to handle that more like Thunderbird. 
> IMHO we can quote the string in any case to be more safe.
> 

yes, let's do it through complete htmlmail.

I would rename the function to quoteNameForMail (may be you have a 
better name) so it's understandable without reading function description.

Do you want to make the *final* version ?

vg Steffen


More information about the TYPO3-team-core mailing list