[TYPO3-core] RFC #13435: t3lib_htmlmail -> from_name in FROM header not quoted

Stefan Galinski sgalinski at df.eu
Fri Feb 26 20:10:21 CET 2010


Benjamin Mack wrote:

> Hey Stefan,
> 
> cool. thank you.
> 
> But I just thought of another question... ;-) (nothing to fix, just to
> think about). Shouldn't we always quote, and remove double-quotes at any
> time the from name and reply-to name (if it's non-empty)? Any reason
> *not* to escape this all the time?
> 
> Otherwise we find another symbol that needs to be checked, and it's a
> leak we have to fix again and again...
> 
> All the best,
> Benni.

Sure, that was my first thought (see version 1 of the patch) too. Steffen 
changed that behaviour in version 2 to handle that more like Thunderbird. 
IMHO we can quote the string in any case to be more safe.

-- 
Stefan Galinski


More information about the TYPO3-team-core mailing list