[TYPO3-core] RFC #13380: Bug: Recursive deletion of alternative page languages

Andreas Otto andreas at otto-hanika.de
Sun Feb 14 11:10:39 CET 2010


Hi Francois,

thanks for taking the time and using the provided testcase.

Am Samstag, den 13.02.2010, 16:49 +0100 schrieb Francois Suter:
> This works perfectly. Thus +1 after reading and testing.
> 
> I just wonder if the better solution would not be to change 
> t3lib_BEfunc::isTableLocalizable(), because a table that acts as a 
> foreign localization container cannot be itself translated IMO. However 
> this method is used in quite a few places throughout the Core and I 
> don't know what the consequences might be. So since this bug is pretty 
> critical, we should go ahead with the version you proposed.

I thought about changing t3lib_BEfunc::isTableLocalizable() as well but
haven't found the time to look at it properly.

> I'm not sure if we need another +1 on the v3 version, but anyone 
> interested should give it a spin, so that it can go into 4.3.2, if Olly 
> agrees.

That's a good question.
Tolleiv gave a +1 to my original patch and introduced v2 - which was a
good intention but contained an error.
I created v3 which is the correct version of v2.
You gave a +1 to v3.
In the end we have 2 +1 for different patches fighting the same cause.


Cheers,
Andreas




More information about the TYPO3-team-core mailing list