[TYPO3-core] FYI #13504: Cannot parse TRUNCATE TABLE in install tool

Oliver Hader oliver at typo3.org
Fri Feb 12 20:27:09 CET 2010


Hi Dmitry,
hi devs,

Am 12.02.10 10:24, schrieb Dmitry Dulepov:
> Hi!
> 
> On 2010-02-11 20:43:28 +0200, Xavier Perseguers said:
>> Applied attached follow-up (Core rev. 6896, DBAL rev. 29941) to use
>> TRUNCATE instead of TRUNCATETABLE in public API (according to today's
>> discussion).
> 
> Hm, you added a function to which I gave -1. This is a violation of our
> commit rules. You must have +1 from a coredev to compensate my -1 before
> you can add it.

You gave your -1 to #13508 but not to this issue which was already
committed as FYI before your feedback concerning #13508. Thus I cannot
set a violation of rules.

Concerning the topic "use TRUNCATE automatically inside the
exec_DELETEquery() method": I don't think, that this is a good idea,
since t3lib_db is mostly a low-level wrapper for database actions. If
someone wants explicitely a DELETE or TRUNCATE query, one must use the
accordant method for that.
If somebody needs an API with a strategy on whether to use DELETE or
TRUNCATE, this would go to a persitence layer instead (e.g. a repository
object that takes the correct method automatically).

Thus +1 for the current situation with this issue #13504 (completely
separated from #13508)

Thanks to everybody for your comments and putting light on the pros and
cons. However, the decision is taken now.

olly
-- 
Oliver Hader
TYPO3 Release Manager 4.3


More information about the TYPO3-team-core mailing list