[TYPO3-core] RFC: #15969: Bug: Task Center - sys_action: setting labels_ignoreprefix from sql query is ignored

[Jigal van Hemert]

Hi,

On 25-10-2010 18:51, Andreas Kiessling wrote:
> Solution: The checkbox is saved in the t2_data of the query and must be
> applied to the $GLOBALS['SOBE']->MOD_SETTINGS so that class
> t3lib_fullsearch recognizes the setting.
>
> The class t3lib_fullsearch itself contains a check for the setting, so i
> am a bit unsure if the setting should be set to "on" or "1" in the
> sysaction class.

Both work; as you've shown in the code below:

>  From class t3lib_fullsearch:
> $GLOBALS['SOBE']->MOD_SETTINGS['labels_noprefix'] =
> $GLOBALS['SOBE']->MOD_SETTINGS['labels_noprefix'] == 1 ? 'on' :
> $GLOBALS['SOBE']->MOD_SETTINGS['labels_noprefix'];

If '1' is stored it's converted to 'on' and otherwise the setting is 
just copied. In the next line it checks for the value 'on'.

+1 by reading and testing

Hopefully the second review will follow a bit sooner.

-- 
Kind regards / met vriendelijke groet,

Jigal van Hemert
skype:jigal.van.hemert
msn: jigal at xs4all.nl
http://twitter.com/jigalvh