[TYPO3-core] RFC: #16134: TYPO3 doesn't always fix permissions for new files

[Christian Kuhn]

Hey.

Attached new versions.

On 12/17/2010 12:05 PM, Oliver Klee wrote:
> 1. I get some skipped tests because I the tests don't find the clear.*
> files:
> $fixtureGifFile = PATH_site . 'tests/t3lib/fixtures/clear.gif';
>
> This is because I'm working on Linux and using the typo3_src/ symlink,
> not a tests/ symlink in the document root.

The fixtures are now referenced relative from the test script. This is a 
straight solution and should work in any case.


> 2. Can we get rid of the @ in the tests and the production code?

I'd agree to Francois and would like to make sure that we do not get a 
warning.


> 3. in t3lib_lock, we don't need an else branch because the Exception
> exits the function:

Fixed, good catch! This happened to me before, I'll keep an eye on it in 
the future.


Thanks
Christian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 16134_04-4.3.diff
Type: text/x-patch
Size: 3393 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20101218/707f46af/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 16134_04-4.4.diff
Type: text/x-patch
Size: 3349 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20101218/707f46af/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 16134_04.diff
Type: text/x-patch
Size: 3358 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20101218/707f46af/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 16134_04-test-4.4.diff
Type: text/x-patch
Size: 11829 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20101218/707f46af/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 16134_04-test.diff
Type: text/x-patch
Size: 11801 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20101218/707f46af/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clear.gif
Type: image/gif
Size: 43 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20101218/707f46af/attachment-0001.gif>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clear.png
Type: image/png
Size: 142 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20101218/707f46af/attachment-0001.png>