[TYPO3-core] RFC: #16737: sendCacheHeaders: Wrong usage of Pragma: public and no-cache

Georg Kuehnberger georg at georg.org
Mon Dec 13 22:45:09 CET 2010


Steffen,
Thanks for your fine feedback.

On 13.12.2010 20:37, Steffen Gebert wrote:
> Hi Georg,
>
> thanks for your contribution!
>
>> - "Pragma: public" as http-header-response, never existed in HTTP/1.0
>> and neighter in HTTP/1.1, as public is implicit, thus should be removed.
> okay, fine with it
>
>> - "Pragma: no-cache" is deprecated in HTTP/1.1 and should also be
>> removed, since "Cache-Control: no-cache ..." is returned anyway and
>> correct.
> Doesn't matter that it's deprecated in 1.1, as the response is 1.0 ;)
> Therefore I would leave it as it is.
OK;

>> Patch provided
> Could you please remove the lines instead of commenting them out in
> future patches? That's why we have version control to keep code clean
> *and* track changes (thus no commenting out needed).
> Attached a version, which removes the Pragma: public.

Got the point (seems the sources in the next else-block with 4 lines of 
#-commented headers mislead me).

Thanks for your patch-improovement.
georg

>
> +1 by reading
>
> Kind regards
> Steffen
>



More information about the TYPO3-team-core mailing list