[TYPO3-core] RFC: #16682: EM: Add missing reports

Steffen Gebert steffen at steffen-gebert.de
Tue Dec 7 15:10:43 CET 2010


On 07.12.10 14:44, Steffen Kamper wrote:
> Hi,
>
> because the high activity here, i committed this one to the em project
> on forge. it will be included with next merge.

Have you already committed it? Can't find it in the EM project repository.

Sorry for not responding earlier, here my review by reading.

Did you remove these lines?

+			//simulate insecure extension, for testing only. This will be removed
+		$extensionCompareList[] = 'phpmyadmin|4.8.1';
+		$extensionCompareList[] = 'xing|1.0.0';
+		$extensionList[] = '"xing"';
+		$extensionCompareList[] = 'chsellector|0.1.1';
+		$extensionList[] = '"chsellector"';

> $this->error·=·t3lib_div::strtoupper($GLOBALS['LANG']->sL('LLL:EXT:em/language/locallang.xml:msg_error'))
I'm not so sure, whether we should do such transformations hardcoded.

> update·older·tha·7·days
-> than

> $row['title']·!==·'TYPO3.org·Main·Repository'
No other way to distinguish?

> $row['lastUpdated']·<·time()·-·(3600*24*7)
$GLOBALS['EXEC_TIME'] ?

> protected·function·getInsecuredExtensionsInSystem()·{
often sometimes uses spaces for intendation

> reports_StatusMainRepositoryExtensions">TYPO3·main·repository·has·extensionslist</label>
Don't exactly understand - "has extension list"?

> as·soon·as·possible,·or·remove·them
no comma, I think

 > ·were·found·on·your·system·but
comma before "but", I think

> Please·go·to·install·tool·and·make·a·database·compare!
Please go to the Install Tool and execute COMPARE in the Database Analyser

> The·Main·Repository·entry·in·table·"sys_ter"·was·not·found.·Please·go·to·extension·manager·/·em·and·import·static·data!
Please go to the Extension Manager and execute "Import static data" in 
the Extension Manager extension "em".
Question: Will this be done by an Upgrade Wizard?

> Please·update·the·repository·in·extension·manager·or·scheduler.
in the Extension Manager
I would leave the scheduler out here.


Kind regards
Steffen

-- 
Steffen Gebert
TYPO3 Core Team Member

Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/


More information about the TYPO3-team-core mailing list